Remove three mixin nodes from #2171#2231
Merged
jacobtylerwalls merged 2 commits intopylint-dev:mainfrom Jul 2, 2023
Merged
Conversation
Follow-up to 082774a.
jacobtylerwalls
added
pylint-tested
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2231 +/- ##
==========================================
- Coverage 92.93% 92.88% -0.06%
==========================================
Files 94 94
Lines 10926 10928 +2
==========================================
- Hits 10154 10150 -4
- Misses 772 778 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DanielNoord
reviewed
Jul 2, 2023
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
DanielNoord
approved these changes
Jul 2, 2023
This was referenced Jul 4, 2023
jacobtylerwalls
commented
Jul 4, 2023
Comment on lines
-1045
to
-1048
| def infer_lhs( | ||
| self, context: InferenceContext | None = None, **kwargs: Any | ||
| ) -> Generator[InferenceResult, None, InferenceErrorInfo | None]: | ||
| return self._infer_attribute(context, **kwargs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Follow-up to 082774a. The DRY benefits of these three mixins (NameNode, AssignNode, AttributeNode) were so minimal that they can just be repeated.
The OperatorNode mixin is pretty huge, so I opted to leave it for now. (The nodes that inherit from it don't have as complicated a series of multiple mixin parents as the nodes changed in this PR, so it's not doing much harm.)